IranAccess/coolify-cli
1
0
Fork 0
forked from mirror/coolify-cli
Code Pull Requests Activity

test: replace assert.NoError with require.NoError across test files

Browse Source 
Aligns remaining test files with the pattern established in 6e80c95.
Using require halts the test immediately on fatal errors instead of
continuing with invalid state.
This commit is contained in:
Andras Bacsai
2026-05-02 18:59:38 +02:00
parent 6e80c95183
commit da3479c65a
7 changed files with 21 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cmd/firewall/allow_test.go
+2 -2
View File
@@ -130,7 +130,7 @@ func TestEmitAllowRevoke_CarriesNonDefaultNamespace(t *testing.T) {
rootCmdFor(inner)
err := emitAllowRevoke(context.Background(), inner, parent, local, fr, false)
assert.NoError(t, err)
require.NoError(t, err)
var post string
for _, c := range fr.calls {
if strings.Contains(c, "-X POST") {
@@ -214,7 +214,7 @@ func TestEmitAllowRevoke_FetchesTokenPerHostWhenOverrideAbsent(t *testing.T) {
rootCmdFor(inner)
err := emitAllowRevoke(context.Background(), inner, parent, local, fr, false)
assert.NoError(t, err)
require.NoError(t, err)
var post string
for _, c := range fr.calls {
if strings.Contains(c, "-X POST") && strings.Contains(c, "/api/v1/firewall/allow") {
cmd/firewall/containers_test.go
+2 -2
View File
@@ -25,7 +25,7 @@ func TestEmitContainers_RunsAndFormatsTable(t *testing.T) {
rootCmdFor(inner)
err := emitContainers(context.Background(), inner, parent, fr)
assert.NoError(t, err)
require.NoError(t, err)
// Discovery command was issued, targeting the default-namespace bridge.
assert.Len(t, fr.calls, 1)
assert.Contains(t, fr.calls[0], "podman ps")
@@ -44,7 +44,7 @@ func TestEmitContainers_EmptyOutput(t *testing.T) {
rootCmdFor(inner)
err := emitContainers(context.Background(), inner, parent, fr)
assert.NoError(t, err)
require.NoError(t, err)
}
// TestEmitContainers_AllNamespaces_FansOutAcrossNetworks verifies that with
cmd/firewall/list_test.go
+4 -3
View File
@@ -7,6 +7,7 @@ import (
"github.com/spf13/cobra"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func TestEmitList_CallsCooldGet(t *testing.T) {
@@ -18,7 +19,7 @@ func TestEmitList_CallsCooldGet(t *testing.T) {
rootCmdFor(inner)
err := emitList(context.Background(), inner, parent, fr)
assert.NoError(t, err)
require.NoError(t, err)
assert.Len(t, fr.calls, 1)
assert.Contains(t, fr.calls[0], "curl")
assert.Contains(t, fr.calls[0], "/api/v1/firewall/allow")
@@ -32,7 +33,7 @@ func TestEmitList_EmptyCoold(t *testing.T) {
rootCmdFor(inner)
err := emitList(context.Background(), inner, parent, fr)
assert.NoError(t, err)
require.NoError(t, err)
}
func TestEmitList_FetchesPerHostTokenWhenOverrideAbsent(t *testing.T) {
@@ -49,7 +50,7 @@ func TestEmitList_FetchesPerHostTokenWhenOverrideAbsent(t *testing.T) {
rootCmdFor(inner)
err := emitList(context.Background(), inner, parent, fr)
assert.NoError(t, err)
require.NoError(t, err)
var ranTokenFetch, ranGet bool
for _, c := range fr.calls {
if strings.Contains(c, "cat /etc/coolify/api-token") {
cmd/firewall/resolve_test.go
+1 -1
View File
@@ -52,7 +52,7 @@ func TestResolveEndpoint_ByRawIP(t *testing.T) {
func TestResolveEndpoint_UnknownRawIP_Synthetic(t *testing.T) {
c, err := resolveEndpoint("10.99.99.99", cs())
assert.NoError(t, err)
require.NoError(t, err)
assert.Empty(t, c.Host)
assert.Equal(t, "10.99.99.99", c.IP.String())
}
cmd/init/plan_test.go
+2 -1
View File
@@ -4,6 +4,7 @@ import (
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/coollabsio/coolify-cli/cmd/common"
)
@@ -36,7 +37,7 @@ func TestValidatePlanFlags(t *testing.T) {
Namespaces: []string{common.DefaultNamespace},
},
})
assert.NoError(t, err)
require.NoError(t, err)
})
t.Run("invalid namespace", func(t *testing.T) {
internal/firewall/coold_client_test.go
+6 -5
View File
@@ -8,6 +8,7 @@ import (
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/coollabsio/coolify-cli/internal/ssh"
)
@@ -84,7 +85,7 @@ func TestCooldApply_SendsJSONPayload(t *testing.T) {
Proto: "tcp", Port: 80,
}
err := CooldApply(context.Background(), fr, "h1", "root", 22, 8443, "wg0", "t", r)
assert.NoError(t, err)
require.NoError(t, err)
assert.Len(t, fr.calls, 1)
assert.Contains(t, fr.calls[0], `"src":"10.0.0.1"`)
assert.Contains(t, fr.calls[0], `"dst":"10.0.0.2"`)
@@ -98,7 +99,7 @@ func TestCooldApply_OmitsProtoWhenEmpty(t *testing.T) {
Src: net.ParseIP("10.0.0.1"), Dst: net.ParseIP("10.0.0.2"),
}
err := CooldApply(context.Background(), fr, "h1", "root", 22, 8443, "wg0", "t", r)
assert.NoError(t, err)
require.NoError(t, err)
// omitempty drops zero port and empty proto — avoids tripping coold's
// "port requires proto" validation.
assert.NotContains(t, fr.calls[0], `"proto"`)
@@ -120,7 +121,7 @@ func TestCooldList_ParsesJSON(t *testing.T) {
]`,
}}
rules, err := CooldList(context.Background(), fr, "h1", "root", 22, 8443, "wg0", "t", "")
assert.NoError(t, err)
require.NoError(t, err)
assert.Len(t, rules, 2)
assert.Equal(t, "h1", rules[0].Host)
assert.Equal(t, "cid:abc123def456", rules[0].Comment)
@@ -135,7 +136,7 @@ func TestCooldList_ParsesJSON(t *testing.T) {
func TestCooldList_EmptyBody(t *testing.T) {
fr := &fakeCooldRunner{}
rules, err := CooldList(context.Background(), fr, "h1", "root", 22, 8443, "wg0", "t", "")
assert.NoError(t, err)
require.NoError(t, err)
assert.Empty(t, rules)
}
@@ -159,7 +160,7 @@ func TestFetchCooldToken_ReadsFile(t *testing.T) {
"/etc/coolify/api-token": "deadbeefcafe\n",
}}
tok, err := FetchCooldToken(context.Background(), fr, "h1", "root", 22)
assert.NoError(t, err)
require.NoError(t, err)
assert.Equal(t, "deadbeefcafe", tok)
}
internal/firewall/discover_test.go
+4 -3
View File
@@ -7,6 +7,7 @@ import (
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func TestParseDiscoverLine(t *testing.T) {
@@ -66,7 +67,7 @@ func TestDiscoverContainers(t *testing.T) {
}}
got, err := DiscoverContainers(context.Background(), r, "h1", "root", 22,
"default", "coolify-default-mesh")
assert.NoError(t, err)
require.NoError(t, err)
assert.Len(t, got, 2)
assert.Equal(t, "api", got[0].Name) // sorted by name
assert.Equal(t, "web", got[1].Name)
@@ -79,7 +80,7 @@ func TestDiscoverContainers_EmptyOutput(t *testing.T) {
r := &fakeRunner{responses: map[string]string{}}
got, err := DiscoverContainers(context.Background(), r, "h1", "root", 22,
"default", "coolify-default-mesh")
assert.NoError(t, err)
require.NoError(t, err)
assert.Empty(t, got)
}
@@ -89,7 +90,7 @@ func TestDiscoverContainers_BadLinesSkipped(t *testing.T) {
}}
got, err := DiscoverContainers(context.Background(), r, "h1", "root", 22,
"default", "coolify-default-mesh")
assert.NoError(t, err)
require.NoError(t, err)
assert.Len(t, got, 1)
assert.Equal(t, "web", got[0].Name)
}