mirror of
https://github.com/go-gitea/gitea.git
synced 2026-06-19 07:36:24 +00:00
bircni
240d0efa7e
Adds `created_unix` as the third column of the `c_u` composite index on the `action` table, changing it from `(user_id, is_deleted)` to `(user_id, is_deleted, created_unix)`. Migration 337 drops and recreates the index. No data is touched. ## Root causes #32333 introduced the `c_u` index to speed up dashboard queries, but defined it as `(user_id, is_deleted)` — without `created_unix`. #3368 The simple query is now efficient enough for the database to actually use `c_u`, but because `created_unix` is absent from the index, the database must load and sort **every** matching row before returning the first page of 20. The existing `c_u_d` index `(created_unix, user_id, is_deleted)` does not help because its leading column is `created_unix`, which can't be used for an equality seek on `user_id`. Those two caused this issue: https://github.com/go-gitea/gitea/issues/38075 With the fix, the database seeks directly to `(user_id=X, is_deleted=false)` and walks `created_unix` in descending order, stopping after 20 rows. Fixes https://github.com/go-gitea/gitea/issues/38075
41 lines
1.2 KiB
Go
41 lines
1.2 KiB
Go
// Copyright 2026 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package v1_27
|
|
|
|
import (
|
|
"context"
|
|
|
|
"gitea.dev/models/db"
|
|
|
|
"xorm.io/xorm/schemas"
|
|
)
|
|
|
|
// AddCreatedUnixToActionUserIsDeletedIndex extends the c_u composite index on
|
|
// the action table to include created_unix, enabling efficient ORDER BY on the
|
|
// dashboard feed query without a full sort of all matching rows.
|
|
func AddCreatedUnixToActionUserIsDeletedIndex(x db.EngineMigration) error {
|
|
// xorm Sync cannot reliably update an index when another index already
|
|
// covers the same columns in a different order (Equal() is order-insensitive).
|
|
// Drop the old c_u index explicitly, then recreate it with the new column set.
|
|
indexes, err := x.Dialect().GetIndexes(x.DB(), context.Background(), "action")
|
|
if err != nil {
|
|
return err
|
|
}
|
|
for _, idx := range indexes {
|
|
if idx.Name == "c_u" {
|
|
if _, err := x.Exec(x.Dialect().DropIndexSQL("action", idx)); err != nil {
|
|
return err
|
|
}
|
|
break
|
|
}
|
|
}
|
|
|
|
newIndex := schemas.NewIndex("c_u", schemas.IndexType)
|
|
newIndex.AddColumn("user_id", "is_deleted", "created_unix")
|
|
if _, err := x.Exec(x.Dialect().CreateIndexSQL("action", newIndex)); err != nil {
|
|
return err
|
|
}
|
|
return nil
|
|
}
|