Files
kima-hub/scripts/create-e2e-user.sh
T
Your Name fc8071b7aa fix: issue triage -- #155 #156 #154 #25, CI hardening, E2E improvements
Issue fixes:
- #155: /api/browse/playlists/parse now handles YouTube/YouTube Music URLs
- #156: stop passing album MBID to verifyArtistName (was calling MB /artist/{id}
  with an album MBID, always 404d); fix spotify trackCount stale value
- #154: remove hardcoded port-3030 detection from getApiBaseUrl -- now returns
  relative URLs by default so any host:port mapping works
- #25 (partial): fix spotify playlist trackCount to use tracks.length instead of
  stale playlist.tracks.total after pagination

Dead code / quality:
- Remove unused rootFolderPath param from processDownload + call sites
- Remove unused req params in route handlers (prefix _req)
- Remove dead push condition from integration.yml job gate
- Remove dead baseUrl constructor param and private field from ApiService
- Fix LibraryTabs hover effect: remove inline style={{ opacity: 0.1 }} that
  overrode Tailwind group-hover; change to group-hover:opacity-10
- Fix mobile tab centering in LibraryTabs (add justify-center)

CI security:
- Mask TEST_PASS before writing to GITHUB_ENV in all three workflow files
- Add missing concurrency block to nightly.yml
- Add username validation + remove credential echo in create-e2e-user.sh
- Fix global.setup.ts error message to mention .env.test

E2E:
- Fix vibe test race condition: replace Promise.race + transient text with
  stable trackCount.or(noData) assertion
- Fix security test flakiness: toBe(beforeCount) -> not.toBeGreaterThan for
  playlist count check (parallel tests can delete playlists concurrently)
- Fix global.setup.ts error message to reference .env.test file

Vibe map:
- Increase cluster label size (13->15 / 10->12 px) and opacity (50->70 / 35->50)
  for slightly better readability
2026-03-17 10:04:03 -05:00

57 lines
2.5 KiB
Bash
Executable File

#!/usr/bin/env bash
# Create the E2E test user inside a running Kima Docker container.
# Usage: bash scripts/create-e2e-user.sh
#
# Reads KIMA_TEST_USERNAME and KIMA_TEST_PASSWORD from env.
# If not set, defaults to username "kima_e2e" and a random password.
# The chosen credentials are printed at the end -- capture them for Playwright.
#
# Env vars:
# KIMA_TEST_USERNAME -- test username (default: kima_e2e)
# KIMA_TEST_PASSWORD -- test password (default: randomly generated)
# KIMA_CONTAINER -- container name (default: kima-test)
set -euo pipefail
CONTAINER="${KIMA_CONTAINER:-kima-test}"
TEST_USER="${KIMA_TEST_USERNAME:-kima_e2e}"
TEST_PASS="${KIMA_TEST_PASSWORD:-$(openssl rand -hex 20)}"
# Validate username to prevent SQL injection via the heredoc
if [[ ! "${TEST_USER}" =~ ^[a-zA-Z0-9_]{3,32}$ ]]; then
echo "[e2e setup] ERROR: KIMA_TEST_USERNAME must be 3-32 alphanumeric/underscore characters" >&2
exit 1
fi
echo "[e2e setup] Creating test user '${TEST_USER}' in container '${CONTAINER}'..."
# Generate bcrypt hash inside the container where bcrypt is installed.
# Pass the password via -e so Docker sets it as an env var -- avoids shell
# quoting and expansion issues with special characters in the password.
HASH=$(docker exec -e "TEST_PASS=${TEST_PASS}" "${CONTAINER}" bash -c '
cd /app/backend && node -e "
const b = require(\"bcrypt\");
b.hash(process.env.TEST_PASS, 10).then(h => process.stdout.write(h));
"
')
# Write SQL to a temp file inside the container to avoid dollar sign expansion.
# The bcrypt hash contains $2b$10$... which bash would mangle if embedded in
# a double-quoted string passed to docker exec.
docker exec -e "HASH=${HASH}" -e "TEST_USER=${TEST_USER}" "${CONTAINER}" bash -c '
# Heredoc is unquoted so ${TEST_USER} and ${HASH} expand (env vars set via -e above).
# SQL single quotes are plain literals here -- no shell escaping needed.
psql -U kima -d kima <<ENDSQL
INSERT INTO "User" (id, username, "passwordHash", role, "onboardingComplete")
VALUES ('\''e2e_test_user_kima'\'', '\''${TEST_USER}'\'', '\''${HASH}'\'', '\''admin'\'', true)
ON CONFLICT (username) DO UPDATE
SET "passwordHash" = EXCLUDED."passwordHash",
role = EXCLUDED.role;
INSERT INTO "UserSettings" ("userId", "playbackQuality", "wifiOnly", "offlineEnabled", "maxCacheSizeMb")
VALUES ('\''e2e_test_user_kima'\'', '\''original'\'', false, false, 10240)
ON CONFLICT ("userId") DO NOTHING;
ENDSQL
'
echo "[e2e setup] Test user '${TEST_USER}' ready."