mirror of
https://github.com/navidrome/navidrome.git
synced 2026-06-19 07:37:15 +00:00
Deluan
32ac53dc9f
Thread the context.Context that goose.UpContext already passes into every migration through to all DB calls: tx.Exec/Query/QueryRow become tx.ExecContext/QueryContext/QueryRowContext with ctx. The shared helpers in migration.go (notice, forceFullRescan, isDBInitialized) gain a ctx parameter and all call sites are updated. No-op migration functions use blank params (_ context.Context, _ *sql.Tx). This is a behavior-preserving change: the SQL, arguments, and ordering of every migration are unchanged; only cancellation/deadline propagation is added. Add a forbidigo lint rule scoped to db/migrations/ that forbids the non-context tx.Exec/Query/QueryRow forms, preventing regression. Signed-off-by: Deluan <deluan@navidrome.org>
49 lines
1.1 KiB
Go
49 lines
1.1 KiB
Go
package migrations
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
|
|
"github.com/navidrome/navidrome/log"
|
|
"github.com/navidrome/navidrome/utils/str"
|
|
"github.com/pressly/goose/v3"
|
|
)
|
|
|
|
func init() {
|
|
goose.AddMigrationContext(upUnescapeLyricsAndComments, downUnescapeLyricsAndComments)
|
|
}
|
|
|
|
func upUnescapeLyricsAndComments(ctx context.Context, tx *sql.Tx) error {
|
|
rows, err := tx.QueryContext(ctx, `select id, comment, lyrics, title from media_file`)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer rows.Close()
|
|
|
|
stmt, err := tx.Prepare("update media_file set comment = ?, lyrics = ? where id = ?")
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
var id, title string
|
|
var comment, lyrics sql.NullString
|
|
for rows.Next() {
|
|
err = rows.Scan(&id, &comment, &lyrics, &title)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
newComment := str.SanitizeText(comment.String)
|
|
newLyrics := str.SanitizeText(lyrics.String)
|
|
_, err = stmt.Exec(newComment, newLyrics, id)
|
|
if err != nil {
|
|
log.Error("Error unescaping media_file's lyrics and comments", "title", title, "id", id, err)
|
|
}
|
|
}
|
|
return rows.Err()
|
|
}
|
|
|
|
func downUnescapeLyricsAndComments(_ context.Context, _ *sql.Tx) error {
|
|
return nil
|
|
}
|