mirror of
https://github.com/navidrome/navidrome.git
synced 2026-06-19 07:37:15 +00:00
Deluan
32ac53dc9f
Thread the context.Context that goose.UpContext already passes into every migration through to all DB calls: tx.Exec/Query/QueryRow become tx.ExecContext/QueryContext/QueryRowContext with ctx. The shared helpers in migration.go (notice, forceFullRescan, isDBInitialized) gain a ctx parameter and all call sites are updated. No-op migration functions use blank params (_ context.Context, _ *sql.Tx). This is a behavior-preserving change: the SQL, arguments, and ordering of every migration are unchanged; only cancellation/deadline propagation is added. Add a forbidigo lint rule scoped to db/migrations/ that forbids the non-context tx.Exec/Query/QueryRow forms, preventing regression. Signed-off-by: Deluan <deluan@navidrome.org>
35 lines
772 B
Go
35 lines
772 B
Go
package migrations
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
|
|
"github.com/pressly/goose/v3"
|
|
)
|
|
|
|
func init() {
|
|
goose.AddMigrationContext(upAddAlbumInfo, downAddAlbumInfo)
|
|
}
|
|
|
|
func upAddAlbumInfo(ctx context.Context, tx *sql.Tx) error {
|
|
_, err := tx.ExecContext(ctx, `
|
|
alter table album
|
|
add description varchar(255) default '' not null;
|
|
alter table album
|
|
add small_image_url varchar(255) default '' not null;
|
|
alter table album
|
|
add medium_image_url varchar(255) default '' not null;
|
|
alter table album
|
|
add large_image_url varchar(255) default '' not null;
|
|
alter table album
|
|
add external_url varchar(255) default '' not null;
|
|
alter table album
|
|
add external_info_updated_at datetime;
|
|
`)
|
|
return err
|
|
}
|
|
|
|
func downAddAlbumInfo(_ context.Context, _ *sql.Tx) error {
|
|
return nil
|
|
}
|