mirror/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2026-06-19 07:37:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Media: Make ::update_size() parameters consistent across image editors.

Browse Source 
Includes:
* Standardizing default values on `null` vs. `false`.
* Updating the documentation to correct parameter types.
* Adding missing parameter descriptions.

Follow-up to [22094].

Props Soean, mukesh27, SergeyBiryukov.
See #64897.
Built from https://develop.svn.wordpress.org/trunk@62517


git-svn-id: http://core.svn.wordpress.org/trunk@61798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
Sergey Biryukov
2026-06-17 11:35:41 +00:00
parent 7755215ff9
commit 94211f8455
4 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
wp-includes/class-wp-image-editor-gd.php
+3 -3
View File
@@ -144,11 +144,11 @@ class WP_Image_Editor_GD extends WP_Image_Editor {
*
* @since 3.5.0
*
* @param int $width
* @param int $height
* @param int|null $width Image width.
* @param int|null $height Image height.
* @return true
*/
protected function update_size( $width = false, $height = false ) {
protected function update_size( $width = null, $height = null ) {
if ( ! $width ) {
$width = imagesx( $this->image );
}
wp-includes/class-wp-image-editor-imagick.php
+3 -2
View File
@@ -247,12 +247,13 @@ class WP_Image_Editor_Imagick extends WP_Image_Editor {
*
* @since 3.5.0
*
* @param int $width
* @param int $height
* @param int|null $width Image width.
* @param int|null $height Image height.
* @return true|WP_Error
*/
protected function update_size( $width = null, $height = null ) {
$size = null;
if ( ! $width || ! $height ) {
try {
$size = $this->image->getImageGeometry();
wp-includes/class-wp-image-editor.php
+2 -2
View File
@@ -201,8 +201,8 @@ abstract class WP_Image_Editor {
*
* @since 3.5.0
*
* @param int $width
* @param int $height
* @param int|null $width Image width.
* @param int|null $height Image height.
* @return true
*/
protected function update_size( $width = null, $height = null ) {
wp-includes/version.php
+1 -1
View File
@@ -16,7 +16,7 @@
*
* @global string $wp_version
*/
$wp_version = '7.1-alpha-62516';
$wp_version = '7.1-alpha-62517';
/**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.