mirror/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2026-06-19 07:37:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Users: Set username, email, and password fields to ltr.

Browse Source 
Usernames, email, and password fields are currently `rtl` in `rtl` locales. However, these fields are primarily standardized to `ltr` character sets and for better experience and readability, should be presented left-to-right in all locales.

Fix username, email, and password fields throughout install and admin to be set to `ltr` text direction.

Props man4toman, sabernhardt, ierwira, agnieszkaszuba, SergeyBiryukov, joyously, hellofromTonya, shibleemehdi, oglekler, audrasjb, sajjad67, huzaifaalmesbah, joedolson.
Fixes #54915.
Built from https://develop.svn.wordpress.org/trunk@61651


git-svn-id: http://core.svn.wordpress.org/trunk@60962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
joedolson
2026-02-16 17:02:47 +00:00
parent 821a799e07
commit b88c13e108
23 changed files with 65 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files
wp-activate.php
+1
View File
@@ -104,6 +104,7 @@ function wpmu_activate_stylesheet() {
.wp-activate-container { width: 90%; margin: 0 auto; }
.wp-activate-container form { margin-top: 2em; }
#submit, #key { width: 100%; font-size: 24px; box-sizing: border-box; }
#key { direction: ltr; }
#language { margin-top: 0.5em; }
.wp-activate-container .error { background: #f66; color: #333; }
span.h3 { padding: 0 8px; font-size: 1.3em; font-weight: 600; }
wp-admin/css/forms-rtl.css
+2
View File
@@ -118,6 +118,8 @@ input[type="radio"]:focus {
}
/* rtl:ignore */
.ltr,
input[type="password"],
input[type="email"],
input[type="url"] {
direction: ltr;
wp-admin/css/forms-rtl.min.css
Vendored
+1 -1
View File
File diff suppressed because one or more lines are too long
wp-admin/css/forms.css
+2
View File
@@ -117,6 +117,8 @@ input[type="radio"]:focus {
}
/* rtl:ignore */
.ltr,
input[type="password"],
input[type="email"],
input[type="url"] {
direction: ltr;
wp-admin/css/forms.min.css
Vendored
+1 -1
View File
File diff suppressed because one or more lines are too long
wp-admin/css/login-rtl.css
+4 -2
View File
@@ -90,6 +90,7 @@ p {
margin-bottom: 15px;
}
/* rtl:ignore */
.login .button.wp-hide-pw {
background: transparent;
border: 1px solid transparent;
@@ -103,7 +104,7 @@ p {
margin: 0;
padding: 5px 9px;
position: absolute;
left: 0;
right: 0;
top: 0;
}
@@ -355,8 +356,9 @@ p {
font-family: Consolas, Monaco, monospace;
}
/* rtl:ignore */
.js.login input.password-input {
padding-left: 2.5rem;
padding-right: 2.5rem;
}
.login form .input,
wp-admin/css/login-rtl.min.css
Vendored
+1 -1
View File
File diff suppressed because one or more lines are too long
wp-admin/css/login.css
+2
View File
@@ -89,6 +89,7 @@ p {
margin-bottom: 15px;
}
/* rtl:ignore */
.login .button.wp-hide-pw {
background: transparent;
border: 1px solid transparent;
@@ -354,6 +355,7 @@ p {
font-family: Consolas, Monaco, monospace;
}
/* rtl:ignore */
.js.login input.password-input {
padding-right: 2.5rem;
}
wp-admin/edit-form-comment.php
+1 -1
View File
@@ -62,7 +62,7 @@ if ( 'approved' === wp_get_comment_status( $comment ) && $comment->comment_post_
<tr>
<td class="first"><label for="email"><?php _e( 'Email' ); ?></label></td>
<td>
<input type="text" name="newcomment_author_email" size="30" value="<?php echo esc_attr( $comment->comment_author_email ); ?>" id="email" />
<input type="text" name="newcomment_author_email" size="30" class="code" value="<?php echo esc_attr( $comment->comment_author_email ); ?>" id="email" />
</td>
</tr>
<tr>
wp-admin/includes/class-wp-posts-list-table.php
+1 -1
View File
@@ -1781,7 +1781,7 @@ class WP_Posts_List_Table extends WP_List_Table {
<div class="inline-edit-group wp-clearfix">
<label class="alignleft">
<span class="title"><?php _e( 'Password' ); ?></span>
<span class="input-text-wrap"><input type="text" name="post_password" class="inline-edit-password-input" value="" /></span>
<span class="input-text-wrap"><input type="text" name="post_password" class="inline-edit-password-input ltr" value="" /></span>
</label>
<span class="alignleft inline-edit-or">
wp-admin/includes/media.php
+1 -1
View File
@@ -3362,7 +3362,7 @@ function attachment_submitbox_metadata() {
<div class="misc-pub-section misc-pub-attachment">
<label for="attachment_url"><?php _e( 'File URL:' ); ?></label>
<input type="text" class="widefat urlfield" readonly="readonly" name="attachment_url" id="attachment_url" value="<?php echo esc_attr( $att_url ); ?>" />
<input type="text" class="widefat urlfield ltr" readonly="readonly" name="attachment_url" id="attachment_url" value="<?php echo esc_attr( $att_url ); ?>" />
<span class="copy-to-clipboard-container">
<button type="button" class="button copy-attachment-url edit-media" data-clipboard-target="#attachment_url"><?php _e( 'Copy URL to clipboard' ); ?></button>
<span class="success hidden" aria-hidden="true"><?php _e( 'Copied!' ); ?></span>
wp-admin/includes/meta-boxes.php
+1 -1
View File
@@ -215,7 +215,7 @@ function post_submit_meta_box( $post, $args = array() ) {
<?php endif; ?>
<input type="radio" name="visibility" id="visibility-radio-password" value="password" <?php checked( $visibility, 'password' ); ?> /> <label for="visibility-radio-password" class="selectit"><?php _e( 'Password protected' ); ?></label><br />
<span id="password-span"><label for="post_password"><?php _e( 'Password:' ); ?></label> <input type="text" name="post_password" id="post_password" value="<?php echo esc_attr( $post->post_password ); ?>" maxlength="255" /><br /></span>
<span id="password-span"><label for="post_password"><?php _e( 'Password:' ); ?></label> <input type="text" name="post_password" id="post_password" class="ltr" value="<?php echo esc_attr( $post->post_password ); ?>" maxlength="255" /><br /></span>
<input type="radio" name="visibility" id="visibility-radio-private" value="private" <?php checked( $visibility, 'private' ); ?> /> <label for="visibility-radio-private" class="selectit"><?php _e( 'Private' ); ?></label><br />
wp-admin/includes/template.php
+1 -1
View File
@@ -493,7 +493,7 @@ function wp_comment_reply( $position = 1, $checkbox = false, $mode = 'single', $
<div class="inside">
<label for="author-email"><?php _e( 'Email' ); ?></label>
<input type="text" name="newcomment_author_email" size="50" value="" id="author-email" />
<input type="text" name="newcomment_author_email" size="50" class="code" value="" id="author-email" />
</div>
<div class="inside">
wp-admin/network/site-info.php
+2 -2
View File
@@ -175,7 +175,7 @@ if ( ! empty( $messages ) ) {
?>
<tr class="form-field">
<th scope="row"><?php _e( 'Site Address (URL)' ); ?></th>
<td><?php echo esc_url( $parsed_scheme . '://' . $details->domain . $details->path ); ?></td>
<td><code><?php echo esc_url( $parsed_scheme . '://' . $details->domain . $details->path ); ?></code></td>
</tr>
<?php
// For any other site, the scheme, domain, and path can all be changed.
@@ -183,7 +183,7 @@ if ( ! empty( $messages ) ) {
?>
<tr class="form-field form-required">
<th scope="row"><label for="url"><?php _e( 'Site Address (URL)' ); ?></label></th>
<td><input name="blog[url]" type="text" id="url" value="<?php echo $parsed_scheme . '://' . esc_attr( $details->domain ) . esc_attr( $details->path ); ?>" /></td>
<td><input name="blog[url]" type="url" id="url" value="<?php echo $parsed_scheme . '://' . esc_attr( $details->domain ) . esc_attr( $details->path ); ?>" /></td>
</tr>
<?php endif; ?>
wp-admin/network/site-settings.php
+19
View File
@@ -150,6 +150,25 @@ if ( ! empty( $messages ) ) {
}
}
$ltr_fields = array(
'siteurl',
'home',
'admin_email',
'new_admin_email',
'mailserver_url',
'mailserver_login',
'mailserver_pass',
'ping_sites',
'permalink_structure',
'category_base',
'tag_base',
'upload_path',
'upload_url_path',
);
if ( in_array( $option->option_name, $ltr_fields, true ) ) {
$class .= ' ltr';
}
if ( str_contains( $option->option_value, "\n" ) ) {
?>
<tr class="form-field">
wp-admin/network/site-users.php
+2 -2
View File
@@ -376,11 +376,11 @@ if ( current_user_can( 'create_users' ) && apply_filters( 'show_network_site_use
<table class="form-table" role="presentation">
<tr>
<th scope="row"><label for="user_username"><?php _e( 'Username' ); ?></label></th>
<td><input type="text" class="regular-text" name="user[username]" id="user_username" /></td>
<td><input type="text" class="regular-text ltr" name="user[username]" id="user_username" /></td>
</tr>
<tr>
<th scope="row"><label for="user_email"><?php _e( 'Email' ); ?></label></th>
<td><input type="text" class="regular-text" name="user[email]" id="user_email" /></td>
<td><input type="text" class="regular-text ltr" name="user[email]" id="user_email" /></td>
</tr>
<tr>
<th scope="row"><label for="new_role_newuser"><?php _e( 'Role' ); ?></label></th>
wp-admin/user-edit.php
+3 -3
View File
@@ -443,7 +443,7 @@ switch ( $action ) {
<table class="form-table" role="presentation">
<tr class="user-user-login-wrap">
<th><label for="user_login"><?php _e( 'Username' ); ?></label></th>
<td><input type="text" name="user_login" id="user_login" value="<?php echo esc_attr( $profile_user->user_login ); ?>" readonly="readonly" class="regular-text" /> <span class="description"><?php _e( 'Usernames cannot be changed.' ); ?></span></td>
<td><input type="text" name="user_login" id="user_login" value="<?php echo esc_attr( $profile_user->user_login ); ?>" readonly="readonly" class="regular-text ltr" /> <span class="description"><?php _e( 'Usernames cannot be changed.' ); ?></span></td>
</tr>
<?php if ( ! IS_PROFILE_PAGE && ! is_network_admin() && current_user_can( 'promote_user', $profile_user->ID ) ) : ?>
@@ -692,7 +692,7 @@ switch ( $action ) {
<button type="button" class="button wp-generate-pw hide-if-no-js" aria-expanded="false"><?php _e( 'Set New Password' ); ?></button>
<div class="wp-pwd hide-if-js">
<div class="password-input-wrapper">
<input type="password" name="pass1" id="pass1" class="regular-text" value="" autocomplete="new-password" spellcheck="false" data-pw="<?php echo esc_attr( wp_generate_password( 24 ) ); ?>" aria-describedby="pass-strength-result" />
<input type="password" name="pass1" id="pass1" class="regular-text ltr" value="" autocomplete="new-password" spellcheck="false" data-pw="<?php echo esc_attr( wp_generate_password( 24 ) ); ?>" aria-describedby="pass-strength-result" />
<div style="display:none" id="pass-strength-result" aria-live="polite"></div>
</div>
<button type="button" class="button wp-hide-pw hide-if-no-js" data-toggle="0" aria-label="<?php esc_attr_e( 'Hide password' ); ?>">
@@ -833,7 +833,7 @@ switch ( $action ) {
<div class="create-application-password form-wrap">
<div class="form-field">
<label for="new_application_password_name"><?php _e( 'New Application Password Name' ); ?></label>
<input type="text" size="30" id="new_application_password_name" name="new_application_password_name" class="input" aria-required="true" aria-describedby="new_application_password_name_desc" spellcheck="false" />
<input type="text" size="30" id="new_application_password_name" name="new_application_password_name" class="input ltr" aria-required="true" aria-describedby="new_application_password_name_desc" spellcheck="false" />
<p class="description" id="new_application_password_name_desc"><?php _e( 'Required to create an Application Password, but not to update the user.' ); ?></p>
</div>
wp-admin/user-new.php
+2 -2
View File
@@ -541,7 +541,7 @@ if ( current_user_can( 'create_users' ) ) {
<table class="form-table" role="presentation">
<tr class="form-field form-required">
<th scope="row"><label for="user_login"><?php _e( 'Username' ); ?> <span class="description"><?php _e( '(required)' ); ?></span></label></th>
<td><input name="user_login" type="text" id="user_login" value="<?php echo esc_attr( $new_user_login ); ?>" aria-required="true" autocapitalize="none" autocorrect="off" autocomplete="off" maxlength="60" /></td>
<td><input name="user_login" type="text" id="user_login" class="ltr" value="<?php echo esc_attr( $new_user_login ); ?>" aria-required="true" autocapitalize="none" autocorrect="off" autocomplete="off" maxlength="60" /></td>
</tr>
<tr class="form-field form-required">
<th scope="row"><label for="email"><?php _e( 'Email' ); ?> <span class="description"><?php _e( '(required)' ); ?></span></label></th>
@@ -600,7 +600,7 @@ if ( current_user_can( 'create_users' ) ) {
<div class="wp-pwd">
<?php $initial_password = wp_generate_password( 24 ); ?>
<div class="password-input-wrapper">
<input type="password" name="pass1" id="pass1" class="regular-text" autocomplete="new-password" spellcheck="false" data-reveal="1" data-pw="<?php echo esc_attr( $initial_password ); ?>" aria-describedby="pass-strength-result" />
<input type="password" name="pass1" id="pass1" class="regular-text ltr" autocomplete="new-password" spellcheck="false" data-reveal="1" data-pw="<?php echo esc_attr( $initial_password ); ?>" aria-describedby="pass-strength-result" />
<div style="display:none" id="pass-strength-result" aria-live="polite"></div>
</div>
<button type="button" class="button wp-hide-pw hide-if-no-js" data-toggle="0" aria-label="<?php esc_attr_e( 'Hide password' ); ?>">
wp-includes/general-template.php
+8 -4
View File
@@ -593,6 +593,8 @@ function wp_login_form( $args = array() ) {
*/
$login_form_bottom = apply_filters( 'login_form_bottom', '', $args );
$direction_style = is_rtl() ? ' style="direction: ltr;"' : '';
$form =
sprintf(
'<form name="%1$s" id="%1$s" action="%2$s" method="post">',
@@ -603,21 +605,23 @@ function wp_login_form( $args = array() ) {
sprintf(
'<p class="login-username">
<label for="%1$s">%2$s</label>
<input type="text" name="log" id="%1$s" autocomplete="username" class="input" value="%3$s" size="20"%4$s />
<input type="text" name="log" id="%1$s" autocomplete="username" class="input" value="%3$s" size="20"%4$s%5$s />
</p>',
esc_attr( $args['id_username'] ),
esc_html( $args['label_username'] ),
esc_attr( $args['value_username'] ),
( $args['required_username'] ? ' required="required"' : '' )
( $args['required_username'] ? ' required="required"' : '' ),
$direction_style
) .
sprintf(
'<p class="login-password">
<label for="%1$s">%2$s</label>
<input type="password" name="pwd" id="%1$s" autocomplete="current-password" spellcheck="false" class="input" value="" size="20"%3$s />
<input type="password" name="pwd" id="%1$s" autocomplete="current-password" spellcheck="false" class="input" value="" size="20"%3$s%4$s />
</p>',
esc_attr( $args['id_password'] ),
esc_html( $args['label_password'] ),
( $args['required_password'] ? ' required="required"' : '' )
( $args['required_password'] ? ' required="required"' : '' ),
$direction_style
) .
$login_form_middle .
( $args['remember'] ?
wp-includes/media-template.php
+2 -2
View File
@@ -547,7 +547,7 @@ function wp_print_media_templates() {
</span>
<span class="setting" data-setting="url">
<label for="attachment-details-two-column-copy-link" class="name"><?php _e( 'File URL:' ); ?></label>
<input type="text" class="attachment-details-copy-link" id="attachment-details-two-column-copy-link" value="{{ data.url }}" readonly />
<input type="text" class="attachment-details-copy-link ltr" id="attachment-details-two-column-copy-link" value="{{ data.url }}" readonly />
<span class="copy-to-clipboard-container">
<button type="button" class="button button-small copy-attachment-url" data-clipboard-target="#attachment-details-two-column-copy-link"><?php _e( 'Copy URL to clipboard' ); ?></button>
<span class="success hidden" aria-hidden="true"><?php _e( 'Copied!' ); ?></span>
@@ -799,7 +799,7 @@ function wp_print_media_templates() {
</span>
<span class="setting" data-setting="url">
<label for="attachment-details-copy-link" class="name"><?php _e( 'File URL:' ); ?></label>
<input type="text" class="attachment-details-copy-link" id="attachment-details-copy-link" value="{{ data.url }}" readonly />
<input type="text" class="attachment-details-copy-link ltr" id="attachment-details-copy-link" value="{{ data.url }}" readonly />
<div class="copy-to-clipboard-container">
<button type="button" class="button button-small copy-attachment-url" data-clipboard-target="#attachment-details-copy-link"><?php _e( 'Copy URL to clipboard' ); ?></button>
<span class="success hidden" aria-hidden="true"><?php _e( 'Copied!' ); ?></span>
wp-includes/version.php
+1 -1
View File
@@ -16,7 +16,7 @@
*
* @global string $wp_version
*/
$wp_version = '7.0-alpha-61650';
$wp_version = '7.0-alpha-61651';
/**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.
wp-login.php
+5 -5
View File
@@ -897,7 +897,7 @@ switch ( $action ) {
<form name="lostpasswordform" id="lostpasswordform" action="<?php echo esc_url( network_site_url( 'wp-login.php?action=lostpassword', 'login_post' ) ); ?>" method="post">
<p>
<label for="user_login"><?php _e( 'Username or Email Address' ); ?></label>
<input type="text" name="user_login" id="user_login" class="input" value="<?php echo esc_attr( $user_login ); ?>" size="20" autocapitalize="off" autocomplete="username" required="required" />
<input type="text" name="user_login" id="user_login" class="input ltr" value="<?php echo esc_attr( $user_login ); ?>" size="20" autocapitalize="off" autocomplete="username" required="required" />
</p>
<?php
@@ -1039,7 +1039,7 @@ switch ( $action ) {
</p>
<div class="wp-pwd">
<input type="password" name="pass1" id="pass1" class="input password-input" size="24" value="" autocomplete="new-password" spellcheck="false" data-reveal="1" data-pw="<?php echo esc_attr( wp_generate_password( 16 ) ); ?>" aria-describedby="pass-strength-result" />
<input type="password" name="pass1" id="pass1" class="input password-input ltr" size="24" value="" autocomplete="new-password" spellcheck="false" data-reveal="1" data-pw="<?php echo esc_attr( wp_generate_password( 16 ) ); ?>" aria-describedby="pass-strength-result" />
<button type="button" class="button button-secondary wp-hide-pw hide-if-no-js" data-toggle="0" aria-label="<?php esc_attr_e( 'Hide password' ); ?>">
<span class="dashicons dashicons-hidden" aria-hidden="true"></span>
@@ -1167,7 +1167,7 @@ switch ( $action ) {
<form name="registerform" id="registerform" action="<?php echo esc_url( site_url( 'wp-login.php?action=register', 'login_post' ) ); ?>" method="post" novalidate="novalidate">
<p>
<label for="user_login"><?php _e( 'Username' ); ?></label>
<input type="text" name="user_login" id="user_login" class="input" value="<?php echo esc_attr( $user_login ); ?>" size="20" autocapitalize="off" autocomplete="username" required="required" />
<input type="text" name="user_login" id="user_login" class="input ltr" value="<?php echo esc_attr( $user_login ); ?>" size="20" autocapitalize="off" autocomplete="username" required="required" />
</p>
<p>
<label for="user_email"><?php _e( 'Email' ); ?></label>
@@ -1519,13 +1519,13 @@ switch ( $action ) {
<form name="loginform" id="loginform" action="<?php echo esc_url( site_url( 'wp-login.php', 'login_post' ) ); ?>" method="post">
<p>
<label for="user_login"><?php _e( 'Username or Email Address' ); ?></label>
<input type="text" name="log" id="user_login"<?php echo $aria_describedby; ?> class="input" value="<?php echo esc_attr( $user_login ); ?>" size="20" autocapitalize="off" autocomplete="username" required="required" />
<input type="text" name="log" id="user_login"<?php echo $aria_describedby; ?> class="input ltr" value="<?php echo esc_attr( $user_login ); ?>" size="20" autocapitalize="off" autocomplete="username" required="required" />
</p>
<div class="user-pass-wrap">
<label for="user_pass"><?php _e( 'Password' ); ?></label>
<div class="wp-pwd">
<input type="password" name="pwd" id="user_pass"<?php echo $aria_describedby; ?> class="input password-input" value="" size="20" autocomplete="current-password" spellcheck="false" required="required" />
<input type="password" name="pwd" id="user_pass"<?php echo $aria_describedby; ?> class="input password-input ltr" value="" size="20" autocomplete="current-password" spellcheck="false" required="required" />
<button type="button" class="button button-secondary wp-hide-pw hide-if-no-js" data-toggle="0" aria-label="<?php esc_attr_e( 'Show password' ); ?>">
<span class="dashicons dashicons-visibility" aria-hidden="true"></span>
</button>
wp-signup.php
+2
View File
@@ -74,6 +74,8 @@ function wpmu_signup_stylesheet() {
.mu_register #user_email,
.mu_register #blogname,
.mu_register #user_name { width: 100%; font-size: 24px; margin: 5px 0; box-sizing: border-box; }
.mu_register input[type="email"],
.mu_register #user_name { direction: ltr; }
.mu_register #site-language { display: block; }
.mu_register .prefix_address,
.mu_register .suffix_address { font-size: 18px; display: inline-block; direction: ltr; }