mirror/phpredis
1
0
Fork 0
mirror of https://github.com/phpredis/phpredis.git synced 2026-06-19 07:35:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix flaky testExists by using deterministic key setup

Browse Source 
The test used rand() to decide which keys to create, making it
possible for $mkeys to be empty. This caused EXISTS to receive an
empty array, resulting in a sporadic assertion failure:
(false) !== 0

Observed in #2825 CI and also in an unrelated branch:
- https://github.com/phpredis/phpredis/actions/runs/24132080914
- https://github.com/phpredis/phpredis/actions/runs/23617186872
This commit is contained in:
武田 憲太郎
2026-04-08 22:56:58 +09:00
committed by Michael Grunder
parent 5b19731649
commit 82bf96c3c0
1 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/RedisTest.php
+4 -7
View File
@@ -1015,17 +1015,14 @@ class Redis_Test extends TestSuite {
/* Add multiple keys */
$mkeys = [];
for ($i = 0; $i < 10; $i++) {
if (rand(1, 2) == 1) {
$mkey = "{exists}key:$i";
$this->redis->set($mkey, $i);
$mkeys[] = $mkey;
}
$mkey = "{exists}key:$i";
$this->redis->set($mkey, $i);
$mkeys[] = $mkey;
}
/* Test passing an array as well as the keys variadic */
$this->assertEquals(count($mkeys), $this->redis->exists($mkeys));
if (count($mkeys))
$this->assertEquals(count($mkeys), $this->redis->exists(...$mkeys));
$this->assertEquals(count($mkeys), $this->redis->exists(...$mkeys));
}
public function testTouch() {